This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Inline across -ffast-math boundary


On 05/03/2016 10:20 AM, Richard Biener wrote:
On Tue, 3 May 2016, Jan Hubicka wrote:

On 21/04/16 12:45, Jan Hubicka wrote:
this patch implements the long promised logic to inline across -ffast-math
boundary when eitehr caller or callee has no fp operations in it.  This is
needed to resolve code quality regression on Firefox with LTO where
-O3/-O2/-Ofast flags are combined and we fail to inline a lot of comdats
otherwise.

-Ofast turns allow-store-data-races param on.
are such params handled by lto?

No, allow-store-data-races is ignored by LTO option handling and whatever is
used at final linktime wins.  THis is because it is --param parameter rather
than optimization option.

Given the nature of the option, I wonder why it was implemented as --param
thing?  It looks like typical optimization option to me and this way we lose
mechanizm to set it with function granuality like we can do other optimization
options.

History.  It was requested multiple times to turn it into a regular
option.

I seem to recall there was a discussion between Ian Taylor and Andrew Macleod whether it should be a --param or an option. Obviously in my mind the --param argument won, though I can't remember who made that case or what the argument was.

Aldy


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]