This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix spec-options.c test case

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Cc: Oleg Endo <oleg dot endo at t-online dot de>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, Dominik Vogt <vogt at linux dot vnet dot ibm dot com>
Date: Mon, 2 May 2016 12:26:09 +0200
Subject: Re: [PATCH] Fix spec-options.c test case
Authentication-results: sourceware.org; auth=none
References: <AM4PR07MB1571BF44DAAEA78762C2F494E4780 at AM4PR07MB1571 dot eurprd07 dot prod dot outlook dot com>

On 05/01/2016 09:52 AM, Bernd Edlinger wrote:

Hi,

I took a closer look at this test case, and I found, except that
it triggers a dejagnu bug, it is also wrong.  I have tested with
a cross-compiler for target=sh-elf and found that the test case
actually FAILs because the foo.specs uses "cppruntime" which
is only referenced in gcc/config/sh/superh.h, but sh/superh.h
is only included for target sh*-superh-elf, see gcc/config.gcc.

This means that it can only pass for target=sh-superh-elf.

The attached patch fixes the testcase and makes it run always,
so that it does no longer triggers the dejagnu bug.

So, two things. Why not use a string in the specs file that exists onall targets? If it's a sh-specific thing we want to test, move why notmove it to gcc.target?



Bernd

Follow-Ups:
- Re: [PATCH] Fix spec-options.c test case
  - From: Bernd Edlinger

References:
- [PATCH] Fix spec-options.c test case
  - From: Bernd Edlinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]