This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix spec-options.c test case


Hi,

I took a closer look at this test case, and I found, except that
it triggers a dejagnu bug, it is also wrong.  I have tested with
a cross-compiler for target=sh-elf and found that the test case
actually FAILs because the foo.specs uses "cppruntime" which
is only referenced in gcc/config/sh/superh.h, but sh/superh.h
is only included for target sh*-superh-elf, see gcc/config.gcc.

This means that it can only pass for target=sh-superh-elf.

The attached patch fixes the testcase and makes it run always,
so that it does no longer triggers the dejagnu bug.


Boot-strapped and reg-tested on x86_64-linux-gnu,
OK for trunk?


Thanks
Bernd.
2016-05-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>

	* gcc.dg/spec-options.c: Run always and add dg-shouldfail if target
	is not sh*-superh-elf.

Index: gcc/testsuite/gcc.dg/spec-options.c
===================================================================
--- gcc/testsuite/gcc.dg/spec-options.c	(Revision 235675)
+++ gcc/testsuite/gcc.dg/spec-options.c	(Arbeitskopie)
@@ -1,8 +1,8 @@
 /* Check that -mfoo is accepted if defined in a user spec
    and that it is not passed on the command line.  */
 /* Must be processed in EXTRA_SPECS to run.  */
-/* { dg-do compile } */
-/* { dg-do run { target sh*-*-* } } */
+/* { dg-do run } */
+/* { dg-shouldfail "" { ! sh*-superh-elf } } */
 /* { dg-options "-B${srcdir}/gcc.dg --specs=foo.specs -tfoo" } */
 
 extern void abort(void);

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]