This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/4] Run profile feedback tests with autofdo
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>,Andi Kleen <andi at firstfloor dot org>,gcc-patches at gcc dot gnu dot org
- Cc: Andi Kleen <ak at linux dot intel dot com>
- Date: Sat, 30 Apr 2016 16:26:06 +0200
- Subject: Re: [PATCH 3/4] Run profile feedback tests with autofdo
- Authentication-results: sourceware.org; auth=none
- References: <1459140266-6902-1-git-send-email-andi at firstfloor dot org> <1459140266-6902-2-git-send-email-andi at firstfloor dot org> <1459140266-6902-3-git-send-email-andi at firstfloor dot org> <5720DA64 dot 7070707 at redhat dot com>
On April 27, 2016 5:27:32 PM GMT+02:00, Bernd Schmidt <bschmidt@redhat.com> wrote:
>On 03/28/2016 06:44 AM, Andi Kleen wrote:
>> From: Andi Kleen <ak@linux.intel.com>
>
>> @@ -313,6 +320,7 @@ proc profopt-execute { src } {
>> # valid, by running it after dg-additional-files-options.
>> foreach ext $prof_ext {
>> profopt-target-cleanup $tmpdir $base $ext
>> + profopt-target-cleanup $tmpdir perf data
>> }
If neither perf nor data depend on $ext then it shouldn't be necessary to loop them over $prof_ext, no?
thanks,
>
>We have this, and then...
>
>> @@ -400,6 +451,7 @@ proc profopt-execute { src } {
>> foreach ext $prof_ext {
>> profopt-target-cleanup $tmpdir $base $ext
>> }
>> + # XXX remove perf.data
>
>... this - does that need to look the same as the above?
>
>> + # Should check if create_gcov exists
>
>So maybe do that?
>
>
>Bernd