This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Allow redefinition of libcilkrts debug macros
- From: Ilya Verbin <iverbin at gmail dot com>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org, Ilya Verbin <ilya dot verbin at intel dot com>, "Balaji V. Iyer" <balaji dot v dot iyer at intel dot com>
- Date: Fri, 29 Apr 2016 14:46:11 +0300
- Subject: Re: Allow redefinition of libcilkrts debug macros
- Authentication-results: sourceware.org; auth=none
- References: <yddlh40a2kt dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <bad54655-5c0b-e6f2-88b8-6929665989d8 at redhat dot com> <yddoa8sx03y dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE>
Hi Rainer!
On Fri, Apr 29, 2016 at 10:58:25 +0200, Rainer Orth wrote:
> > On 04/26/2016 08:04 AM, Rainer Orth wrote:
> >> When working on a couple of Cilk Plus issues lately (PRs target/60290,
> >> target/68945), I noticed that you have to modify the libcilkplus sources
> >> to enable various debugging output. This seems silly, and the following
> >> patch allows defining them from the command line.
> >>
> >> Tested on i386-pc-solaris2.12 and sparc-sun-solaris2.12.
> >>
> >> Ok for mainline?
> >>
> >> Rainer
> >>
> >>
> >> 2016-04-07 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
> >>
> >> * runtime/except-gcc.cpp (DEBUG_EXCEPTIONS): Allow redefinition.
> >> * runtime/cilk_fiber.h (FIBER_DEBUG): Likewise.
> >> * runtime/scheduler.h (REDPAR_DEBUG): Likewise.
> > Ilya will have to chime in here -- we're a downstream consumer of the Cilk+
> > runtime. So these patches need to go into Intel's tree first, then Ilya
> > can bring them into the GCC tree.
>
> I suspected that much. It would be good to have a libcilkrts/README.gcc
> describing the rules which changes can go into the gcc tree directly,
> which need to go upstream first, and how. libo and libsanitizer already
> have this.
Could you please submit your patch to <www.cilkplus.org/submit-cilk-contribution>?
All patches for libcilkrts/* should go there first in order to avoid possible
license issues, or possible losses during the merge.
Thanks,
-- Ilya