This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Move "X +- C1 CMP C2 to X CMP C2 -+ C1" to match.pd
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Marc Glisse <marc dot glisse at inria dot fr>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 29 Apr 2016 10:07:58 +0200
- Subject: Re: Move "X +- C1 CMP C2 to X CMP C2 -+ C1" to match.pd
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 02 dot 1604241828250 dot 12491 at laptop-mg dot saclay dot inria dot fr> <CAFiYyc0+cNVAynu62ZPDNxnGJBBGKGYXpHo5_XAzSLS1Zg8OGw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 20 dot 1604262140440 dot 2084 at laptop-mg dot saclay dot inria dot fr> <alpine dot DEB dot 2 dot 02 dot 1604270731180 dot 3445 at laptop-mg dot saclay dot inria dot fr> <CAFiYyc1H0FGi=XFYjF=GVNnp9PbH1o+5J8KSY=iE65UfpE=9xQ at mail dot gmail dot com> <alpine dot DEB dot 2 dot 20 dot 1604282154400 dot 1878 at laptop-mg dot saclay dot inria dot fr>
On Thu, Apr 28, 2016 at 10:15 PM, Marc Glisse <marc.glisse@inria.fr> wrote:
> On Wed, 27 Apr 2016, Richard Biener wrote:
>
>>> --- trunk4/gcc/fold-const.h (revision 235452)
>>> +++ trunk4/gcc/fold-const.h (working copy)
>>> @@ -13,20 +13,22 @@ WARRANTY; without even the implied warra
>>> FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
>>> for more details.
>>>
>>> You should have received a copy of the GNU General Public License
>>> along with GCC; see the file COPYING3. If not see
>>> <http://www.gnu.org/licenses/>. */
>>>
>>> #ifndef GCC_FOLD_CONST_H
>>> #define GCC_FOLD_CONST_H
>>>
>>> +#include <flag-types.h>
>>> +
>>
>>
>> I think the canonical way is to include options.h where you include
>> fold-const.h ...
>> (ick)
>>
>> Doesn't the prototype serve as a forward declaration only and thus
>> including
>> options.h from gimple-match-head.c is enough?
>
>
> Doesn't look like it. If I remove this include, I get build failures for
> a large part of the C front-end (through c-family/c-common.h) and
> tree-ssa-scopedtables.c. Including options.h in those 2 files seems to
> work (I didn't check if all the files in config/ that include
> fold-const.h also indirectly include options.h). If you really think
> that's better, I'll do it...
Another option is to move the enum declaration from flag-types.h to
coretypes.h. I think I like that best.
Richard.
> --
> Marc Glisse