Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

[Matthias Klose <doko at ubuntu dot com>]

On 27.04.2016 17:56, Dhole wrote:
> Thanks again for the review Bernd,
>
> On 16-04-27 01:33:47, Bernd Schmidt wrote:
> > > +  epoch = strtoll (source_date_epoch, &endptr, 10);
> > > +  if ((errno == ERANGE && (epoch == LLONG_MAX || epoch == LLONG_MIN))
> > > +      || (errno != 0 && epoch == 0))
> > > +    fatal_error (UNKNOWN_LOCATION, "environment variable $SOURCE_DATE_EPOCH: "
> > > +		 "strtoll: %s\n", xstrerror(errno));
> > > +  if (endptr == source_date_epoch)
> > > +    fatal_error (UNKNOWN_LOCATION, "environment variable $SOURCE_DATE_EPOCH: "
> > > +		 "No digits were found: %s\n", endptr);
> > > +  if (*endptr != '\0')
> > > +    fatal_error (UNKNOWN_LOCATION, "environment variable $SOURCE_DATE_EPOCH: "
> > > +		 "Trailing garbage: %s\n", endptr);
> > > +  if (epoch < 0)
> > > +    fatal_error (UNKNOWN_LOCATION, "environment variable $SOURCE_DATE_EPOCH: "
> > > +		 "Value must be nonnegative: %lld \n", epoch);
> >
> > These are somewhat unusual for error messages, but I think the general
> > principle of no capitalization probably applies, so "No", "Trailing", and
> > "Value" should be lowercase.
>
> Done.
>
> > > +  time_t source_date_epoch = (time_t) -1;
> > > +
> > > +  source_date_epoch = get_source_date_epoch ();
> >
> > First initialization seems unnecessary. Might want to merge the declaration
> > with the initialization.
>
> And done.
>
> I'm attaching the updated patch with the two minor issues fixed.

committed.