This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] [ARC] Add TLS support.




On 15/04/16 10:58, Claudiu Zissulescu wrote:
TLS mods for ARC backend.

OK to apply?
Claudiu


This is using an inefficient TLS global dynamic implementation that would not
be expected in a new and/or well-tuned port.
However, if you have to work with a legacy runtime, that can't be helped.

+(define_insn "tls_gd_load"
..
+   ; if the linker has to patch this into IE, we need a long insns

Typo: a long insn.

arc_emit_call_tls_get_addr is missing a start-of-function comment.

Otherwise this is OK.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]