This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4/4] Add make autoprofiledbootstrap
- From: Bernd Schmidt <bschmidt at redhat dot com>
- To: Andi Kleen <andi at firstfloor dot org>, gcc-patches at gcc dot gnu dot org
- Cc: Andi Kleen <ak at linux dot intel dot com>
- Date: Wed, 27 Apr 2016 17:36:09 +0200
- Subject: Re: [PATCH 4/4] Add make autoprofiledbootstrap
- Authentication-results: sourceware.org; auth=none
- References: <1459140266-6902-1-git-send-email-andi at firstfloor dot org> <1459140266-6902-2-git-send-email-andi at firstfloor dot org> <1459140266-6902-3-git-send-email-andi at firstfloor dot org> <1459140266-6902-4-git-send-email-andi at firstfloor dot org>
On 03/28/2016 06:44 AM, Andi Kleen wrote:
From: Andi Kleen <ak@linux.intel.com>
Add support for profiledbootstrap with autofdo. Will be useful
to get better testing coverage of autofdo.
Is this the only purpose? I'll admit this is the patch I like least out
of the series.
The autofdo'ed compiler is ~7% faster on insn-recog.i (vs ~11% for
profiledfeedback), and ~4% faster for tramp3d-v4 (vs 10% for
profiledfeedback)
So it seems like we get worse results than with a feature we already
have, so I don't quite see the value.
+AUTO_PROFILE = gcc-auto-profile -c 1000000
Shouldn't this be from $(srcdir) somewhere?
+# get from configure?
+CREATE_GCOV = create_gcov
Probably.
Please remove diffs against autogenerated files when submitting patches.
+ifeq ($(shell cat ../stage_current),stageautofeedback)
+$(CXX_AND_OBJCXX_OBJS): CFLAGS += -fauto-profile=cc1plus.fda
+$(CXX_AND_OBJCXX_OBJS): cc1plus.fda
+endif
+cc1.fda: ../stage1-gcc/cc1$(exeext) ../prev-gcc/$(PERF_DATA)
+ $(CREATE_GCOV) -binary ../stage1-gcc/cc1$(exeext) -gcov cc1.fda -profile ../prev-gcc/$(PERF_DATA) -gcov_version 1
+
These Makefile bits all looks somewhat hackish to me. I'll defer to
build system maintainers if they like it better.
Bernd