This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 06/18] move reg_equivs out of gc memory

From: Bernd Schmidt <bschmidt at redhat dot com>
To: tbsaunde+gcc at tbsaunde dot org, gcc-patches at gcc dot gnu dot org
Date: Mon, 25 Apr 2016 16:22:37 +0200
Subject: Re: [PATCH 06/18] move reg_equivs out of gc memory
Authentication-results: sourceware.org; auth=none
References: <1461133342-10794-1-git-send-email-tbsaunde+gcc at tbsaunde dot org> <1461133342-10794-7-git-send-email-tbsaunde+gcc at tbsaunde dot org>

On 04/20/2016 08:22 AM, tbsaunde+gcc@tbsaunde.org wrote:

From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>

It used the gc vector type, but isn't marked as a gc route, and appears
to be manually managed, so it should be safe to use the normal heap
vector.

gcc/ChangeLog:

2016-04-19  Trevor Saunders  <tbsaunde+gcc@tbsaunde.org>

	* ira-emit.c (emit_move_list): Adjust.
	* ira.c (fix_reg_equiv_init): Likewise.
	(update_equiv_regs): Likewise.
	(ira): Likewise.
	(do_reload): Likewise.
	* reload.c (subst_reloads): Likewise.
	* reload.h (reg_equivs): Move to the normal heap.
	* reload1.c (grow_reg_equivs): Adjust.
	(reload): Likewise.
	(eliminate_regs_1): Likewise.
	(elimination_effects): Likewise.
	(init_eliminable_invariants): Likewise.
	(free_reg_equiv): Likewise.

I wonder whether this is really worth it. The improvement is marginal,and there is a real cost associated with patches such as this one whenpeople need to work across multiple branches.



Bernd

References:
- [PATCH 00/18] towards removing rtx_insn_list and rtx_expr_list
  - From: tbsaunde+gcc
- [PATCH 06/18] move reg_equivs out of gc memory
  - From: tbsaunde+gcc

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]