This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR target/70155: Use SSE for TImode load/store
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Ilya Enkovich <enkovich dot gnu at gmail dot com>
- Date: Mon, 25 Apr 2016 16:18:53 +0200
- Subject: Re: [PATCH] PR target/70155: Use SSE for TImode load/store
- Authentication-results: sourceware.org; auth=none
- References: <20160425125145 dot GA5326 at intel dot com>
On Mon, Apr 25, 2016 at 2:51 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Tested on Linux/x86-64. OK for trunk?
> + /* FIXME: Since the CSE pass may change dominance info, which isn't
> + expected by the fwprop pass, call free_dominance_info to
> + invalidate dominance info. Otherwise, the fwprop pass may crash
> + when dominance info is changed. */
> + if (TARGET_64BIT)
> + free_dominance_info (CDI_DOMINATORS);
> +
Please resolve the above problem first, target-dependent sources are
not the place to apply band-aids for middle-end problems. The thread
with the proposed fix died in [1].
[1] https://gcc.gnu.org/ml/gcc/2016-03/msg00143.html
Also, I find _32 and _64 suffixes confusing, maybe better would be to
use timode_ and dimode_ prefixes everywhere?
Uros.