This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2] (header usage fix) include c++ headers in system.h
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Rich Felker <dalias at libc dot org>, David Edelsohn <dje dot gcc at gmail dot com>, nd <nd at arm dot com>, Michael Matz <matz at suse dot de>, Oleg Endo <oleg dot endo at t-online dot de>
- Date: Fri, 22 Apr 2016 11:08:13 +0100
- Subject: Re: [PATCH 2/2] (header usage fix) include c++ headers in system.h
- Authentication-results: sourceware.org; auth=none
- References: <5719F6C8 dot 1060506 at arm dot com>
On Fri, Apr 22, 2016 at 11:02:48AM +0100, Szabolcs Nagy wrote:
> Some gcc source files include standard headers after
> "system.h" but those headers may declare and use poisoned
> symbols, they also cannot be included before "system.h"
> because they might depend on macro definitions from there,
> so they must be included in system.h.
>
> This patch fixes the use of <list>, <map>, <set>, <vector>
> and <algorithm> headers, by using appropriate
> INCLUDE_{LIST, MAP, SET, VECTOR, ALGORITHM} macros.
> (Note that there are some other system header uses which
> did not get fixed.)
>
> Build tested on aarch64-*-gnu, sh-*-musl, x86_64-*-musl and
> bootstrapped x86_64-*-gnu (together with PATCH 1/2).
>
> is this ok for AIX?
> OK for trunk?
The AArch64 part of this is OK.
Thanks,
James