This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFC: C++ PATCH to adjust empty class parameter passing ABI
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>, Jonathan Wakely <jwakely at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Wed, 13 Apr 2016 21:18:30 +0200
- Subject: Re: RFC: C++ PATCH to adjust empty class parameter passing ABI
- Authentication-results: sourceware.org; auth=none
- References: <570D5A44 dot 6060105 at redhat dot com> <20160413153217 dot GT19207 at tucnak dot redhat dot com> <570E6B9B dot 1010200 at redhat dot com> <570E99E6 dot 3040603 at redhat dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Apr 13, 2016 at 03:11:34PM -0400, Jason Merrill wrote:
> commit 761983a023b5217ef831a43f423779940c788ecf
> Author: Jason Merrill <jason@redhat.com>
> Date: Tue Apr 12 13:16:50 2016 -0400
>
> gcc/
> * cfgexpand.c (pass_expand::execute): Handle attribute abi_warning.
> * expr.c (expand_expr_real_1): Likewise.
> gcc/cp/
> * call.c (empty_class_msg, mark_for_abi_warning): New.
> (build_call_a): Use them.
> * decl.c (store_parm_decls): Use mark_for_abi_warning.
> * error.c (pp_format_to_string): New.
I think you should put a space into the attribute name instead of _
to make it clear that it is not an attribute users can use directly in their
code through __attribute__.
Otherwise it looks reasonable to me.
Jakub