This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Splitting up gcc/omp-low.c?

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Thomas Schwinge <thomas at codesourcery dot com>
Cc: Martin Jambor <mjambor at suse dot cz>, Jakub Jelinek <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org
Date: Wed, 13 Apr 2016 20:20:19 +0200
Subject: Re: Splitting up gcc/omp-low.c?
Authentication-results: sourceware.org; auth=none
References: <20151207111758 dot GA24234 at virgil dot suse dot cz> <20151207112243 dot GF24234 at virgil dot suse dot cz> <20151209131930 dot GS5675 at tucnak dot redhat dot com> <87si3b4mk3 dot fsf at kepler dot schwinge dot homeip dot net> <5668638A dot 5030500 at redhat dot com> <20151210080835 dot GX5675 at tucnak dot redhat dot com> <87y48o5toc dot fsf at hertz dot schwinge dot homeip dot net> <87twj54hx6 dot fsf at hertz dot schwinge dot homeip dot net> <570E8417 dot 3080208 at redhat dot com> <87r3e94cku dot fsf at hertz dot schwinge dot homeip dot net>

On 04/13/2016 07:56 PM, Thomas Schwinge wrote:

Best way to present this might be to do
diff -du old-omp-low.c <each of the split files>.


OK, I found Git "-C5%" produce something very similar to that;
0001-Split-up-gcc-omp-low.c-plain.patch.xz attached.

That looks much better. However, the //OMPWHATEVER comments are notreally all that helpful. I think the next step would be to clear out allthis stuff including the OMPCUT markers, and also to start with aninitial patch that includes everything that actually modifies coderather than moving it (omp_is_reference seems to be the major thing here).



Bernd

Follow-Ups:
- Re: Splitting up gcc/omp-low.c?
  - From: Thomas Schwinge

References:
- Re: Splitting up gcc/omp-low.c?
  - From: Thomas Schwinge
- Re: Splitting up gcc/omp-low.c?
  - From: Thomas Schwinge
- Re: Splitting up gcc/omp-low.c?
  - From: Bernd Schmidt
- Re: Splitting up gcc/omp-low.c?
  - From: Thomas Schwinge

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]