This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Don't include DECL_UIDs in tree-sra fancy names for -fdump-final-insns= (PR c++/70594)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: Martin Jambor <mjambor at suse dot cz>, Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 12 Apr 2016 20:47:57 +0200
- Subject: Re: [PATCH] Don't include DECL_UIDs in tree-sra fancy names for -fdump-final-insns= (PR c++/70594)
- Authentication-results: sourceware.org; auth=none
- References: <20160412145427 dot GV19207 at tucnak dot redhat dot com> <06F4B65D-FBCA-4653-B7A7-D47FF748F251 at suse dot de> <20160412155516 dot GZ19207 at tucnak dot redhat dot com> <140A6BFE-E821-4CDF-B463-8489EDA2A2A6 at suse dot de>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Apr 12, 2016 at 08:19:57PM +0200, Richard Biener wrote:
> >So you mean add another hash table that maps DECL_UIDs to these SRA
> >counters? Because if we dump there any number of say FIELD_DECL, it
> >would
> >be desirable to use the same number on any further fancy names with
> >that
> >FIELD_DECL.
> >Do it unconditionally, or just for flag_dump_final_insns?
>
> I'd have just added sth to the dumps so you can manually connect the XXX in the name with the UID.
But the names appear in all the gimple, ipa? and rtl dumps after that, so
if it e.g. just printed a SRA uid -> DECL uid mapping in tree-sra*-details
dump, then one would not have it easily accessible when looking all the
other dumps.
If it is just guarded with flag_dump_final_insns != NULL, then we have the
previous behavior almost all the time, just for -fcompare-debug effectively
force -nouid flag into all the dumps for the fancy names. But it is easy
to just remove that flag from the command line to have more details, IMHO
that is better than just looking up some mapping dump somewhere.
Jakub