This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR68953] Fix pdr accesses order
- From: Richard Biener <rguenther at suse dot de>
- To: Sebastian Pop <sebpop at gmail dot com>,Tom de Vries <Tom_deVries at mentor dot com>
- Cc: Tobias Grosser <tobias at grosser dot es>,GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 09 Apr 2016 13:26:27 +0200
- Subject: Re: [PATCH, PR68953] Fix pdr accesses order
- Authentication-results: sourceware.org; auth=none
- References: <570757AE dot 7070306 at mentor dot com> <CAFk3UF8bBUuAd-=VNKzKEqKRdHRtHRdagvzZA5EH_8hOQWUzXA at mail dot gmail dot com>
On April 9, 2016 6:07:19 AM GMT+02:00, Sebastian Pop <sebpop@gmail.com> wrote:
>On Fri, Apr 8, 2016 at 2:03 AM, Tom de Vries <Tom_deVries@mentor.com>
>wrote:
>> pdr_0 (read
>> in gimple stmt: _9 = yu[_8][0];
>> data accesses: { S_4[i1, i2] -> [1, 0, 1 + i1] }
>
>data access should be { S_4[i1, i2] -> [1, 1 + i1, 0] }
>
>> subscript sizes: { [1, i1, 0] : i1 >= 0 and i1 <= 3 }
>> )
>[...]
>> I'm not really sure how this is supposed to be fixed. I imagine that
>we should do one of 3:
>> 1. we change the order in the access functions
>> 2. we change the order in the subscript_sizes
>> 3. we keep the orders as they are, but don't intersect them directly
>> but do an order inversion before.
>>
>> I've picked 1, since that was the easiest for me to implement (but
>I'm not sure if by doing so, I've broken any hardcoded graphite
>assumptions).
>
>1 is the right fix: both access functions and subscript sizes should
>be in the same order.
>If Richi agrees, ok to commit.
OK.
Richard.
>Thanks,
>Sebastian