This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH] PR 70501, ICE in verify ctor sanity


On 04/06/16 07:49, Jason Merrill wrote:
On 04/05/2016 05:21 PM, Nathan Sidwell wrote:
On 04/05/16 12:40, Jason Merrill wrote:

It's not clear to me that we really need a TARGET_EXPR for vector values.  Since
one element of a vector can't refer to another, we don't need the ctx->ctor
handling.  Perhaps we should handle vectors like we do PMF types in
cxx_eval_bare_aggregate?

That may be abstractly better, but we do currently wrap constructors in
target_exprs for vector compound_literals (which is what I was
following).  See the get_target_expr_sfinae  calls in
finish_compound_literal for instance.  That happens for  the '(v4si){(0,
0)}' subexpression of the testcase.

Sure, but that also seems unnecessary; vector rvalues don't have object identity
the way class and array rvalues do.

I'll investigate further.  At least we have a fallback now.

nathan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]