This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, testsuite/ARM] Skip pr70496.c for cortex-m devices
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Kyrylo Tkachov <Kyrylo dot Tkachov at arm dot com>
- Date: Wed, 6 Apr 2016 12:16:01 +0100
- Subject: Re: [PATCH, testsuite/ARM] Skip pr70496.c for cortex-m devices
- Authentication-results: sourceware.org; auth=none
- References: <6491652 dot xk5pjihgLD at e108577-lin>
On Wed, Apr 6, 2016 at 12:03 PM, Thomas Preudhomme
<thomas.preudhomme@foss.arm.com> wrote:
> Hi,
>
> Testcase in gcc.target/arm/pr70496.c uses an .arm directive so assumes the
> target has an ARM execution state. This patch adds a dg-skip-if directive to
> skip that test on Cortex-M targets since they don't have such an execution
> state.
>
> ChangeLog entry is as follows:
>
>
> *** gcc/testsuite/ChangeLog ***
>
> 2016-04-06 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> PR testsuite/70553
> * gcc.target/arm/pr70496.c: Skip for ARM Cortex-M targets.
>
>
> diff --git a/gcc/testsuite/gcc.target/arm/pr70496.c
> b/gcc/testsuite/gcc.target/arm/pr70496.c
> index
> 89957e2c7a75cb89153b3e3fc34d8051b6a997d1..548a8243059ddaec63ed897dc67f4751d806a065
> 100644
> --- a/gcc/testsuite/gcc.target/arm/pr70496.c
> +++ b/gcc/testsuite/gcc.target/arm/pr70496.c
> @@ -1,6 +1,7 @@
> /* { dg-do assemble } */
> /* { dg-options "-mthumb -O2" } */
> /* { dg-require-effective-target arm_thumb2_ok } */
> +/* { dg-skip-if "does not have ARM state" { arm_cortex_m } } */
>
> int i;
> void
>
Ok.
Looks obvious and sorry about the inadvertent breakage.
Ramana
>
>
>
> Is this ok for trunk?
>
> Best regards,
>
> Thomas