Re: Fix for PR70498 in Libiberty Demangler

[Bernd Schmidt <bschmidt at redhat dot com>]

On 04/01/2016 12:21 PM, Marcel Böhme wrote:
> This fixes the write access violation detailed in
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70498 (and a few other
> unreported cases).
>
> Sometimes length-variables for strings and arrays are of type long
> other times of type int. Since cp-demangle.h exports structs and
> methods with length-variables of type int, this has been made
> consistent in cp-demangle.c.

Patches need to be bootstrapped and regression tested, and patch 
submissions should include which target this was done on.

Ideally you'd also want to include testcases along with your patches, 
although I'm not entirely sure how we can arrange for this type of 
problem to be tested.

Lastly, for this specific patch, I have trouble seeing how it fixes 
anything. I'd need a more detailed explanation of how the problem 
happens in the first place.


Bernd