This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, AArch64] Fix for PR67896 (C++ FE cannot distinguish __Poly{8,16,64,128}_t types)
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Roger Ferrer Ibáñez <rofirrim at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, richard dot earnshaw at arm dot com, marcus dot shawcroft at arm dot com, law at redhat dot com
- Date: Fri, 1 Apr 2016 10:48:24 +0100
- Subject: Re: [PATCH, AArch64] Fix for PR67896 (C++ FE cannot distinguish __Poly{8,16,64,128}_t types)
- Authentication-results: sourceware.org; auth=none
- References: <CAGeEQ1jwdwXt7uPPb8k1n9f187ADVZit80hCmkS=z6oo0G_-MA at mail dot gmail dot com> <20160119170145 dot GA24258 at arm dot com> <CAGeEQ1ivp2gL+pwjcQGBVg0J2mdY6NHTr_4JJ4cPm7WbLvR23g at mail dot gmail dot com> <20160125121547 dot GA9334 at arm dot com>
On Mon, Jan 25, 2016 at 12:15:48PM +0000, James Greenhalgh wrote:
> On Wed, Jan 20, 2016 at 09:27:41PM +0100, Roger Ferrer Ibáñez wrote:
> > Hi James,
> >
> > > This patch looks technically correct to me, though there is a small
> > > style issue to correct (in-line below), and your ChangeLogs don't fit
> > > our usual style.
> >
> > thank you very much for the useful comments. I'm attaching a new
> > version of the patch with the style issues (hopefully) ironed out.
>
> Thanks, this version of the patch looks correct to me.
>
> > > > P.S.: I haven't signed the copyright assignment to the FSF. The change
> > > > is really small but I can do the paperwork if required.
>
> I can't commit it on your behalf until we've heard back regarding whether
> this needs a copyright assignment to the FSF, but once I've heard I'd
> be happy to commit this for you. I'll expand the CC list a bit further
> to see if we can get an answer on that.
>
> Thanks again for the analysis and patch.
This patch should also be backported to GCC 5, which has the same bug.
I've done that as r234665 as the merge was clean after a bootstrap and
test cycle on aarch64-none-linux-gnu.
Thanks,
James