This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix 69845

From: Jeff Law <law at redhat dot com>
To: Richard Henderson <rth at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 24 Mar 2016 11:52:37 -0600
Subject: Re: [PATCH] Fix 69845
Authentication-results: sourceware.org; auth=none
References: <56F1837D dot 1000508 at redhat dot com>

On 03/22/2016 11:40 AM, Richard Henderson wrote:

In PR68142 you added a check for overflow + __INT_MIN__.
I can't figure out why the check for __INT_MIN__, except
that it seems specific to the test case you examined.

And indeed, this test case shows how things go wrong
with other distributed folding leading to overflow.

I added two tests, one signed, one unsigned.  The second
verifies that we do still fold for the defined-overflow case.

Ok?

Richi ack'd.  I went ahead and committed this to the trunk.

jeff

References:
- [PATCH] Fix 69845
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]