This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Joseph Myers <joseph at codesourcery dot com>, Jeff Law <law at redhat dot com>
- Date: Thu, 17 Mar 2016 08:57:36 -0700
- Subject: Re: PING: [PATCH] PR driver/70192: Properly set flag_pie and flag_pic
- Authentication-results: sourceware.org; auth=none
- References: <CAMe9rOpcNKKO0f-YwLcmAV+CXDwErrdevRKi3a638kDm3XhtUw at mail dot gmail dot com> <56EABCA9 dot 80505 at redhat dot com> <CAMe9rOojkNqd18U4pFZ3EP_upHn4BjUb4CwYJ5mpAFgDxyiVrg at mail dot gmail dot com> <CAMe9rOroQ+XMnOyPkPGNs+WGaKKZv7tx-Byuo=Qm2wPBxvo4cA at mail dot gmail dot com> <56EAC89F dot 1070206 at redhat dot com> <CAMe9rOqzj-0uX5shkpi8F9SDwWfQrFrJSqp-NovaJ6Lyu0U4yg at mail dot gmail dot com> <56EACC07 dot 3030101 at redhat dot com> <CAMe9rOr+xJwPRrBY7jH1+uLHAP2HS-FQXOQ-QMr7ESb1y=7iVg at mail dot gmail dot com> <56EAD387 dot 9060601 at redhat dot com>
On Thu, Mar 17, 2016 at 8:55 AM, Bernd Schmidt <bschmidt@redhat.com> wrote:
> On 03/17/2016 04:26 PM, H.J. Lu wrote:
>>
>> On Thu, Mar 17, 2016 at 8:23 AM, Bernd Schmidt <bschmidt@redhat.com>
>> wrote:
>>>
>>> On 03/17/2016 04:13 PM, H.J. Lu wrote:
>>>>
>>>> We can add an effective target, something like ignore_pic_pie, and
>>>> use it instead of *-*-darwin*.
>>>
>>>
>>>
>>> That should have been done _before_ committing the patch in a form that
>>> was
>>> not approved.
>>>
>>
>> How should we move forward?
>
>
> Maybe an effective target pic_default, which tests whether __PIC__ is
> defined without any options. Please prepare a patch.
>
That isn't sufficient for Darwin since it ignores -fno-pic and -fno-pie.
--
H.J.