This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix missing warning with bool (PR c/67854)
- From: Jeff Law <law at redhat dot com>
- To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 1 Mar 2016 09:31:26 -0700
- Subject: Re: [PATCH] Fix missing warning with bool (PR c/67854)
- Authentication-results: sourceware.org; auth=none
- References: <20160224163122 dot GR14947 at redhat dot com>
On 02/24/2016 09:31 AM, Marek Polacek wrote:
The following is another issue with macros from system headers. In this case
bool is defined in a system header to expand to _Bool and the "is promoted to"
warning didn't trigger because of that. The fix is to use the expanded location.
Bootstrapped/regtested on x86_64-linux, ok for trunk?
2016-02-24 Marek Polacek <polacek@redhat.com>
PR c/67854
* gimplify.c (gimplify_va_arg_expr): Use expanded location for the
"is promoted to" warning.
* gcc.dg/pr67854.c: New test.
This isn't a regression, so I put it in my gcc-7 bucket. Is this
something we really need to address in gcc-6?
FWIW, I think the patch is technically fine.
Jeff