This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 69495: unused-label warning does not tell which flag triggered it
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Manfred Schwarb <manfred99 at gmx dot ch>, gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 26 Feb 2016 19:09:23 +0100
- Subject: Re: [Patch, Fortran] PR 69495: unused-label warning does not tell which flag triggered it
- Authentication-results: sourceware.org; auth=none
- References: <CAKwh3qgaiXOFrjNXijPBcJ8SWsc5ET0LbTknBiQ8iSD6va+p7w at mail dot gmail dot com> <56B1C681 dot 4020508 at gmx dot ch> <CAKwh3qjzLosu5XhkJ8-TbYZqwB1nQX6hqKXySZcwZnKAQ65fjg at mail dot gmail dot com> <56B2756F dot 2030908 at gmx dot ch> <alpine dot DEB dot 2 dot 10 dot 1602032224200 dot 17774 at digraph dot polyomino dot org dot uk> <CAKwh3qhAwPLLRTiy9N+pbJVB0OTuE3eyAsY8ySksDCdsDdUFmA at mail dot gmail dot com> <CAKwh3qg_8Ze0kYwWU4gKB1OuQqm27BAuyag6Gd4Q6HN=+HNgSA at mail dot gmail dot com>
double-ping ...
2016-02-12 0:29 GMT+01:00 Janus Weil <janus@gcc.gnu.org>:
> ping!
>
> 2016-02-05 19:19 GMT+01:00 Janus Weil <janus@gcc.gnu.org>:
>> Hi all,
>>
>> I have slightly updated the patch now to avoid string-breaking issues
>> (even if it may not be a problem at all, as mentioned by Jospeh). Also
>> I removed the questionable part in intrinsic.c that I was not sure
>> about.
>>
>> This version of the patch should not be too far from obvious now. Ok for trunk?
>>
>> Cheers,
>> Janus
>>
>>
>>
>> 2016-02-03 23:27 GMT+01:00 Joseph Myers <joseph@codesourcery.com>:
>>> On Wed, 3 Feb 2016, Manfred Schwarb wrote:
>>>
>>>> There are 2 things with translation, and there is a third issue:
>>>> - As you noticed, breaking things differently means translation has to be
>>>> done again.
>>>> - Normally, each string is translated independently, and depending on the
>>>> language there may be lack of context (e.g. adjectives get different
>>>> suffixes
>>>> depending on the noun).
>>>
>>> I believe gettext works fine with (compile-time) string constant
>>> concatenation - that is, extracts the whole concatenated string for
>>> translation, so these are non-issues. What doesn't work includes:
>>>
>>> * Runtime concatenation of strings or otherwise putting English fragments
>>> together at runtime.
>>>
>>> * String constant concatenation where one of the concatenated pieces comes
>>> from a macro expansion.
>>>
>>> * The argument for translation being a conditional expression:
>>>
>>> error (cond ? "message 1" : "message 2");
>>>
>>> (in this case, only one of the messages may be extracted for translation,
>>> so you need to mark both of them up with appropriate macros such as G_).
>>>
>>> --
>>> Joseph S. Myers
>>> joseph@codesourcery.com