This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC, PR68580] Handle pthread_create error in tsan testsuite
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- Cc: Tom de Vries <Tom_deVries at mentor dot com>, Dmitry Vyukov <dvyukov at google dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Dodji Seketeli <dodji at redhat dot com>, Kostya Serebryany <kcc at google dot com>, "thread-sanitizer at googlegroups dot com" <thread-sanitizer at googlegroups dot com>
- Date: Thu, 18 Feb 2016 22:31:02 +0100
- Subject: Re: [RFC, PR68580] Handle pthread_create error in tsan testsuite
- Authentication-results: sourceware.org; auth=none
- References: <HE1PR07MB090529F0173D75A4621D5FD6E4AC0 at HE1PR07MB0905 dot eurprd07 dot prod dot outlook dot com> <56C1AC43 dot 4070309 at mentor dot com> <CACT4Y+b0nXH3NWhWHiaMt_M82kUuMckOnehY1DsOJ9d=4qi0Ug at mail dot gmail dot com> <HE1PR07MB0905578859D3EC1C8AFFD5CFE4AC0 at HE1PR07MB0905 dot eurprd07 dot prod dot outlook dot com> <56C5ACA7 dot 2030708 at mentor dot com> <HE1PR07MB09058FEAE504C246CB700788E4AF0 at HE1PR07MB0905 dot eurprd07 dot prod dot outlook dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Feb 18, 2016 at 08:19:22PM +0000, Bernd Edlinger wrote:
> > Could you add 'PR testsuite/68580' to the log entry when committing?
> >
>
> Yes, of course, thanks.
>
> Could someone take the time and review this patch?
> I don't think it can cause any trouble for gcc-6 and/or gcc-5
> even at stage 4.
>
> Is it OK for trunk and gcc-5-branch?
Ok.
> >> 2016-02-15 Bernd Edlinger<bernd.edlinger@hotmail.de>
> >>
> >> * c-c++-common/tsan/pr65400-1.c (v, q, o): Make 8-byte aligned.
> >>
> >> --- gcc/testsuite/c-c++-common/tsan/pr65400-1.c.jj 2015-03-19
> >> 08:53:38.000000000 +0100
> >> +++ gcc/testsuite/c-c++-common/tsan/pr65400-1.c 2016-02-15
> >> 11:09:18.852320827 +0100
> >> @@ -7,9 +7,9 @@
> >> #include "tsan_barrier.h"
> >>
> >> static pthread_barrier_t barrier;
> >> -int v;
> >> -int q;
> >> -int o;
> >> +int v __attribute__((aligned(8)));
> >> +int q __attribute__((aligned(8)));
> >> +int o __attribute__((aligned(8)));
> >> extern void baz4 (int *);
> >>
> >> __attribute__((noinline, noclone)) int
> >
Jakub