This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: add check for aarch64 in check_effective_target_section_anchors()
- From: Prathamesh Kulkarni <prathamesh dot kulkarni at linaro dot org>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: gcc Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 15 Feb 2016 23:02:13 +0530
- Subject: Re: add check for aarch64 in check_effective_target_section_anchors()
- Authentication-results: sourceware.org; auth=none
- References: <CAAgBjMk9gjgKWbDLJQO5ue=XStQQabn5+mn1UDi02GrkrKi_UQ at mail dot gmail dot com> <20160215135434 dot GA11788 at arm dot com>
On 15 February 2016 at 19:24, James Greenhalgh <james.greenhalgh@arm.com> wrote:
> On Thu, Feb 11, 2016 at 11:03:23PM +0530, Prathamesh Kulkarni wrote:
>> Hi,
>> aarch64 supports section anchors but it appears
>> check_effective_target_section_anchors() doesn't contain entry for it.
>> This patch adds for entry for aarch64.
>> OK for trunk ?
>
> OK. I presume you tested this, and the testcases this enables PASS without
> issue?
Yes, the unsupported test-cases for section anchors pass.
http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/233425-target-supports/aarch64-none-linux-gnu/diff-gcc-rh60-aarch64-none-linux-gnu-default-default-default.txt
Tested with aarch64-none-linux-gnu, aarch64-none-elf, and aarch64_be-none-elf.
Committed as r233426.
Thanks,
Prathamesh
>
> Thanks,
> James
>
>> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
>> index 645981a..66fb1ea 100644
>> --- a/gcc/testsuite/lib/target-supports.exp
>> +++ b/gcc/testsuite/lib/target-supports.exp
>> @@ -5467,7 +5467,8 @@ proc check_effective_target_section_anchors { } {
>> } else {
>> set et_section_anchors_saved 0
>> if { [istarget powerpc*-*-*]
>> - || [istarget arm*-*-*] } {
>> + || [istarget arm*-*-*]
>> + || [istarget aarch64*-*-*] } {
>> set et_section_anchors_saved 1
>> }
>> }
>
>