This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR driver/69779: fix bogus cleanup code used by libgccjit affecting s390x
- From: Jeff Law <law at redhat dot com>
- To: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 12 Feb 2016 11:17:57 -0700
- Subject: Re: [PATCH] PR driver/69779: fix bogus cleanup code used by libgccjit affecting s390x
- Authentication-results: sourceware.org; auth=none
- References: <1455253960-23499-1-git-send-email-dmalcolm at redhat dot com> <56BD8F06 dot 6050709 at redhat dot com> <1455300759 dot 29792 dot 18 dot camel at redhat dot com>
On 02/12/2016 11:12 AM, David Malcolm wrote:
The problem is that struct spec_list's "name" field is declared const:
const char *name; /* name of the spec. */
and likewise for the "name" field within struct spec_list_1:
const char *const name;
Some are statically allocated, others are dynamically allocated.
If I convert them to:
char *name; /* name of the spec. */
and:
char *const name;
I'm not suggesting you remove the const for thees things.
It seems simpler to keep the "const" on those string fields, and cast
it away when cleaning up the dynamically-allocated ones (as in the
candidate patch).
Is it really necessary to cast it away to call free? I suppose it is.
OK without the twiddle.
jeff