This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR69291, RTL if-conversion bug

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Richard Biener <rguenther at suse dot de>
Cc: gcc-patches at gcc dot gnu dot org
Date: Wed, 10 Feb 2016 14:35:48 +0100
Subject: Re: [PATCH] Fix PR69291, RTL if-conversion bug
Authentication-results: sourceware.org; auth=none
References: <alpine dot LSU dot 2 dot 11 dot 1602101400100 dot 31122 at t29 dot fhfr dot qr> <56BB3B64 dot 3040606 at redhat dot com> <alpine dot LSU dot 2 dot 11 dot 1602101430430 dot 31122 at t29 dot fhfr dot qr>

On 02/10/2016 02:33 PM, Richard Biener wrote:


But if you prefer I can instead test the following

Index: gcc/ifcvt.c
===================================================================
--- gcc/ifcvt.c (revision 233262)
+++ gcc/ifcvt.c (working copy)
@@ -1274,7 +1274,7 @@ noce_try_store_flag_constants (struct no
        && CONST_INT_P (XEXP (a, 1))
        && CONST_INT_P (XEXP (b, 1))
        && rtx_equal_p (XEXP (a, 0), XEXP (b, 0))
-      && noce_operand_ok (XEXP (a, 0))
+      && REG_P (XEXP (a, 0))
        && if_info->branch_cost >= 2)


I think I prefer this, but actually maybe OBJECT_P is safe enough.


Bernd

References:
- [PATCH] Fix PR69291, RTL if-conversion bug
  - From: Richard Biener
- Re: [PATCH] Fix PR69291, RTL if-conversion bug
  - From: Bernd Schmidt
- Re: [PATCH] Fix PR69291, RTL if-conversion bug
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]