Re: [PATCH v3] PR48344: Fix unrecognizable insn error with -fstack-limit-register=r2

[Bernd Schmidt <bschmidt at redhat dot com>]

On 01/27/2016 07:12 PM, Kelvin Nilsen wrote:
> +/* During execution of handle_common_deferred_options (), the Pmode
> +   variable cannot be used because it has not yet been initialized.
> +   For this reason, handling of the OPT_fstack_limit_register_ and
> +   OPT_fstack_limit_symbol_ options is deferred until execution
> +   of finish_deferred_option_handling (), which is invoked following
> +   target-specific initialization.
> +
> +   The variable opt_fstack_limit_symbol_arg represents the name
> +   of the register specified in an OPT_fstack_limit_symbol_ command
> +   line option, or NULL to represent that no OPT_fstack_limit_symbol_
> +   option is active.
> +
> +   The variable opt_fstack_limit_register_no represents the number of
> +   the register specified in an OPT_fstack_limit_register_
> +   command-line option, or -1 to indicate that no
> +   OPT_fstack_limit_register_ option is active.  (Legal register
> +   numbers are all >= 0.)
> +
> +   Note that these two command-line options are mutually exclusive.
> +   If both are specified, subsequent option processing overwrites
> +   earlier option processing. */
> +
> +static const char *opt_fstack_limit_symbol_arg = NULL;
> +static int opt_fstack_limit_register_no = -1;
> +

My suggestion would be: make these global, and move the code to 
initialize the rtx to init_emit_once. Then use a much shorter comment 
here ("Store values of -fstack-limit arguments for use by 
init_emit_once."). Also, note that there should be two spaces at the end 
of a sentence, even at the end of each comment.


Bernd