This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: C++ PATCH for c++/69688 (bogus error with -Wsign-compare)

From: Jason Merrill <jason at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 5 Feb 2016 17:36:21 -0500
Subject: Re: C++ PATCH for c++/69688 (bogus error with -Wsign-compare)
Authentication-results: sourceware.org; auth=none
References: <20160205223243 dot GA3321 at redhat dot com>

On 02/05/2016 05:32 PM, Marek Polacek wrote:

   if (TREE_CODE (type) == ERROR_MARK)
     return NULL_TREE;

+  /* Here, DECL may change value; purge caches.  */
+  clear_fold_cache ();
+  clear_cv_cache ();
+
   if (MAYBE_CLASS_TYPE_P (type))

This should happen after computing the value to be stored, not before.Also, could you combine those two functions into one? There's no reasonfor callers such as this to need to call two different functions.


Jason

Follow-Ups:
- Re: C++ PATCH for c++/69688 (bogus error with -Wsign-compare)
  - From: Marek Polacek

References:
- C++ PATCH for c++/69688 (bogus error with -Wsign-compare)
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]