This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, MIPS] Fix PR target/68273, passing args in wrong regs
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: gcc-patches at gcc dot gnu dot org, sellcey at imgtec dot com, Richard Biener <richard dot guenther at gmail dot com>, "Moore, Catherine" <Catherine_Moore at mentor dot com>, "Maciej W. Rozycki" <macro at imgtec dot com>, Matthew Fortune <Matthew dot Fortune at imgtec dot com>, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Thu, 04 Feb 2016 12:09:51 +0100
- Subject: Re: [Patch, MIPS] Fix PR target/68273, passing args in wrong regs
- Authentication-results: sourceware.org; auth=none
- References: <a80cfc11-c2a6-4142-b66f-a522f227d6ba at BAMAIL02 dot ba dot imgtec dot org> <1454538638 dot 3232 dot 125 dot camel at ubuntu-sellcey> <1E4CE37C-986B-4DEB-A936-BA9A6C117A0B at comcast dot net>
> So this doesnât fix aarch64, c6x, epiphany, ia64, iq2000, rs6000, rx, sparc,
> tilegx, tilepro or xtensa.
> :-( Thatâs one of the problems by having each port copy and paste swaths of
> :code from other ports to express the same thing instead of ports sharing
> :just one copy of code. My port is also broken in the same way
> :(currently).
Yes, fixing a compiler bug by changing the ABI is a no-no, and the argument of
the compatibility with LLVM has IMO little merit since it's a GCC extension.
> Iâm curious why the caller of the hook canât grab the main variant, if it
> wants. If it did this, then all the ports are fixed wrt this issue.
Or just fix PRE wrt the alignment discrepancy, which looks a lot safer to me.
It's not because this works on x86 that this is necessarily correct for all
the other architectures, especially the strict-alignment architectures.
--
Eric Botcazou