This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix #69251 - [6 Regression] ICE in unify_array_domain on a flexible array member
- From: Martin Sebor <msebor at gmail dot com>
- To: Jason Merrill <jason at redhat dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 03 Feb 2016 22:23:23 -0700
- Subject: Re: [PATCH] fix #69251 - [6 Regression] ICE in unify_array_domain on a flexible array member
- Authentication-results: sourceware.org; auth=none
- References: <569D9FAB dot 90705 at gmail dot com> <56A16774 dot 8040609 at redhat dot com> <56A16A86 dot 3030102 at gmail dot com> <56A6538C dot 9030602 at gmail dot com> <56B0A0E7 dot 9010606 at redhat dot com> <56B15600 dot 5070509 at gmail dot com> <56B24B34 dot 10902 at redhat dot com>
I've committed the patch with the changes below. Just to clarify
my concern (since put to rest):
It was impossible to have null TYPE_MAX_VALUE until you introduced that
in compute_array_index_type, and thus we didn't test for it; if we
aren't doing that anymore I can't imagine where it would come from now.
The patch with the TYPE_MAX_VALUE checks has been in place for
several weeks. Although unlikely, it seemed conceivable that
a change could have gone in since then that has introduced
a dependency on the domain being non-null for flexible array
members in some corner case. But you know the code far better
than me (and the changes being committed) so I trust you when
you say the removal is safe.
Martin