This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch, MIPS] Patch for PR 68400, a mips16 bug
- From: "Moore, Catherine" <Catherine_Moore at mentor dot com>
- To: "Steve Ellcey " <sellcey at imgtec dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: "matthew dot fortune at imgtec dot com" <matthew dot fortune at imgtec dot com>
- Date: Thu, 28 Jan 2016 16:23:18 +0000
- Subject: RE: [Patch, MIPS] Patch for PR 68400, a mips16 bug
- Authentication-results: sourceware.org; auth=none
- References: <1d526ceb-716b-4c64-bf3b-bb9a1222d0aa at BAMAIL02 dot ba dot imgtec dot org>
> -----Original Message-----
> From: Steve Ellcey [mailto:sellcey@imgtec.com]
> Sent: Tuesday, January 26, 2016 3:43 PM
> To: gcc-patches@gcc.gnu.org
> Cc: matthew.fortune@imgtec.com; Moore, Catherine
> Subject: [Patch, MIPS] Patch for PR 68400, a mips16 bug
>
> Here is a patch for PR6400. The problem is that and_operands_ok was
> checking one operand to see if it was a memory_operand but MIPS16
> addressing is more restrictive than what the general memory_operand
> allows. The fix was to call mips_classify_address if TARGET_MIPS16 is set
> because it will do a more complete mips16 addressing check and reject
> operands that do not meet the more restrictive requirements.
>
> I ran the GCC testsuite with no regressions and have included a test case as
> part of this patch.
>
> OK to checkin?
>
> Steve Ellcey
> sellcey@imgtec.com
>
>
> 2016-01-26 Steve Ellcey <sellcey@imgtec.com>
>
> PR target/68400
> * config/mips/mips.c (and_operands_ok): Add MIPS16 check.
>
>
>
This is OK.
Thanks, Catherine