This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA (tree.h): C++ PATCH for c++/67407 (ICE with protected access)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 28 Jan 2016 16:09:48 +0100
- Subject: Re: RFA (tree.h): C++ PATCH for c++/67407 (ICE with protected access)
- Authentication-results: sourceware.org; auth=none
- References: <56AA2DDF dot 9000105 at redhat dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Jan 28, 2016 at 10:03:59AM -0500, Jason Merrill wrote:
> In this testcase, the problem was that we were checking DERIVED_FROM_P,
> which uses dfs_walk_once and thus BINFO_MARKED, in the middle of a
> dfs_walk_once_accessible, which also uses BINFO_MARKED, and the marks from
> one walk were confusing the other walk. Fixed by moving these binfo walking
> functions to use a hash_set instead of BINFO_MARKED.
>
> After this change, there are no uses of BINFO_MARKED left in the source
> tree, so I'm inclined to rename it to BINFO_LANG_FLAG_0. OK?
LGTM.
Do you see any measurable compatile time differences with this patch
on some large C++ preprocessed source (say some boost one)?
Jakub