This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics.


On Wed, 2016-01-27 at 12:01 +0100, Dominik Vogt wrote:
> The attached patch removes a blank line after an error message.
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69006

Presumably this was exposed by the stricter testing I added to lib/gcc
-dg.exp in r232837?

>    else if (num_matches > 1)
>      {
> -      error_at (loc, "ambiguous overload for intrinsic: %s\n",
> +      error_at (loc, "ambiguous overload for intrinsic: %s",
>  	     IDENTIFIER_POINTER (DECL_NAME (ob_fndecl)));
>        return error_mark_node;
>      }

I'm not a reviewer, but FWIW the removal of the trailing "\n" looks
sane to me.

Should this code be using %qs rather than %s? (or somesuch, or is that
a gcc 7 thing)

Dave


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]