This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics.
- From: David Malcolm <dmalcolm at redhat dot com>
- To: vogt at linux dot vnet dot ibm dot com, gcc-patches at gcc dot gnu dot org
- Cc: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Date: Wed, 27 Jan 2016 09:22:19 -0500
- Subject: Re: [PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics.
- Authentication-results: sourceware.org; auth=none
- References: <20160127110126 dot GA7243 at linux dot vnet dot ibm dot com>
On Wed, 2016-01-27 at 12:01 +0100, Dominik Vogt wrote:
> The attached patch removes a blank line after an error message.
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69006
Presumably this was exposed by the stricter testing I added to lib/gcc
-dg.exp in r232837?
> else if (num_matches > 1)
> {
> - error_at (loc, "ambiguous overload for intrinsic: %s\n",
> + error_at (loc, "ambiguous overload for intrinsic: %s",
> IDENTIFIER_POINTER (DECL_NAME (ob_fndecl)));
> return error_mark_node;
> }
I'm not a reviewer, but FWIW the removal of the trailing "\n" looks
sane to me.
Should this code be using %qs rather than %s? (or somesuch, or is that
a gcc 7 thing)
Dave