Re: [PATCH][ARM,AARCH64] target/PR68674: relayout vector_types in expand_expr

[Christian Bruel <christian dot bruel at st dot com>]

On 01/25/2016 08:06 PM, Christophe Lyon wrote:
> On 22 January 2016 at 12:56, Richard Biener <richard.guenther@gmail.com> wrote:
> > On Fri, Jan 22, 2016 at 12:41 PM, Christian Bruel
> > <christian.bruel@st.com> wrote:
> > > On 01/19/2016 04:18 PM, Richard Biener wrote:
> > > > maybe just if (currently_expanding_to_rtl)?
> > > >
> > > > But yes, this looks like a safe variant of the fix.
> > > >
> > > > Richard.
> > > thanks, currently_expanding_to_rtl works perfectly. So the final version.
> > > I added a test for each target.
> > Ok.
> Hi,
>
> This small patch is needed to make the new test pass on arm hard-float
> targets (eg. arm-none-linux-gnueabihf).
>
> I'm not sure it counts as obvious, so here it is.
> OK?
>
> Christophe.
>
> DATE  Christophe Lyon  <christophe.lyon@linaro.org>
>
>      * gcc.target/arm/pr68674.c: Check and use arm_fp effective target.

At least that's fine with me.

Just for the story, arm_neon.h ends up to include stubs.h from the 
sysroot. Depending on the glibc version it might assert that we cannot 
use softfp abi with a sysroot built with hardfp.

thanks for spotting this Christophe,

> > Thanks,
> > Richard.
> >
> > > bootstrapped / tested for :
> > >      unix/-m32/-march=i586
> > >      unix
> > >
> > >      arm-qemu/
> > >      arm-qemu//-mfpu=neon
> > >      arm-qemu//-mfpu=neon-fp-armv8
> > >
> > >      aarch64-qemu