This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix use of declare'd vars by routine procedures.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: James Norris <jnorris at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 22 Jan 2016 11:39:20 +0100
- Subject: Re: [PATCH] Fix use of declare'd vars by routine procedures.
- Authentication-results: sourceware.org; auth=none
- References: <569C1D44 dot 8080404 at codesourcery dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sun, Jan 17, 2016 at 05:01:24PM -0600, James Norris wrote:
> The attached patch addresses the failure of declare-4 in the libgomp testsuite.
> The primary failure was the use a variable with a link clause for an OpenACC
> routine function. The patch changes the test to use a create clause. The patch
> also adds checking of those globals used within an OpenACC routine function.
> Additional gcc testing is also included in the patch.
>
> Regtested and bootstrapped on x86_64.
The testcase change is obviously fine, please install it separately.
As for the extra error, I think it would be better to diagnose this during
gimplification, that way you do it for all FEs, plus you have the omp
context in there, etc. The error wording is weird, the diagnostic
should make it clear use of what is invalid in what and why.
Jakub