This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] libitm: Disable testing transaction-safe exceptions on Darwin and AIX.
- From: Mike Stump <mikestump at comcast dot net>
- To: Torvald Riegel <triegel at redhat dot com>
- Cc: Dominique d'Humières <dominiq at lps dot ens dot fr>, Jonathan Wakely <jwakely at redhat dot com>, libstdc++ at gcc dot gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jack Howarth <howarth at bromo dot med dot uc dot edu>
- Date: Thu, 21 Jan 2016 10:19:43 -0800
- Subject: Re: [PATCH] libitm: Disable testing transaction-safe exceptions on Darwin and AIX.
- Authentication-results: sourceware.org; auth=none
- References: <1EF9008F-5418-4A35-AA1F-9931E464B0AA at lps dot ens dot fr> <1453230646 dot 23593 dot 13 dot camel at localhost dot localdomain> <20160119192001 dot GK15084 at redhat dot com> <572007D4-C174-4181-8CE9-88D930581163 at lps dot ens dot fr> <1453389937 dot 4592 dot 3 dot camel at localhost dot localdomain> <DC392244-3DBD-4DF1-AB7F-1689F6B30E9F at lps dot ens dot fr> <C0EE0B6E-72F4-4B44-8B0E-4BD424871A03 at lps dot ens dot fr> <6EEDF783-378A-4F21-89A5-6FD0914837F5 at comcast dot net> <1453400116 dot 4592 dot 11 dot camel at localhost dot localdomain>
On Jan 21, 2016, at 10:15 AM, Torvald Riegel <triegel@redhat.com> wrote:
> On Thu, 2016-01-21 at 10:06 -0800, Mike Stump wrote:
>> On Jan 21, 2016, at 9:29 AM, Dominique d'Humières <dominiq@lps.ens.fr> wrote:
>>> // { dg-do run { target { ! { *-*-darwin* powerpc-ibm-aix* } } } }
>>
>> A comment to hint that this has something to do with weak undefined would be nice.
>
> Here's the patch I prepared (which indeed includes a comment).
>
> OK for trunk? I'm not quite sure whether this qualifies as a
> regression, but having an additional test that now fails is one I guess.
> <libitm-safeexc-unsupported.patch>
A simple testsuite fixup like this is still ok. From a darwin, AIX perspective it is fine. If either the transaction or the libstdc++ people like it, I think we’re set.