This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/15] add more coalescing to simplify constraints


On 21/01/16 14:22, Matthew Wahab wrote:
On 15/01/16 17:14, Sebastian Pop wrote:
From: Sebastian Pop <s.pop@samsung.com>

2015-12-30  Aditya Kumar  <aditya.k7@samsung.com>
        Sebastian Pop  <s.pop@samsung.com>

    * graphite-dependences.c (constrain_domain): Add call to isl_*_coalesce.
    (add_pdr_constraints): Same.
    (scop_get_reads): Same.
    (scop_get_must_writes): Same.
    (scop_get_may_writes): Same.
    (scop_get_original_schedule): Same.
    (extend_schedule): Same.
    (apply_schedule_on_deps): Same.
    (carries_deps): Same.
    (compute_deps): Same.
    (scop_get_dependences): Same.
    * graphite-isl-ast-to-gimple.c
    (translate_isl_ast_to_gimple::generate_isl_schedule): Same.
    * graphite-optimize-isl.c (get_schedule_for_band): Same.
    (get_schedule_for_band_list): Same.
    (get_schedule_map): Same.
    (apply_schedule_map_to_scop): Same.
    * graphite-sese-to-poly.c (build_pbb_scattering_polyhedrons): Same.
    (build_loop_iteration_domains): Same.
    (add_condition_to_pbb): Same.
    (add_param_constraints): Same.
    (pdr_add_memory_accesses): Same.
    (pdr_add_data_dimensions): Same.
---
  gcc/graphite-dependences.c       | 63 ++++++++++++++++++----------------------
  gcc/graphite-isl-ast-to-gimple.c |  2 ++
  gcc/graphite-optimize-isl.c      | 12 ++++----
  gcc/graphite-sese-to-poly.c      | 28 ++++++++++++------
  4 files changed, 56 insertions(+), 49 deletions(-)

diff --git a/gcc/graphite-optimize-isl.c b/gcc/graphite-optimize-isl.c
index 9626e96..15dd5b0 100644
--- a/gcc/graphite-optimize-isl.c
+++ b/gcc/graphite-optimize-isl.c
[..]
  static isl_union_map *
  get_schedule_map (isl_schedule *schedule)
  {
-  isl_band_list *bandList = isl_schedule_get_band_forest (schedule);
-  isl_union_map *schedule_map = get_schedule_for_band_list (bandList);
+  isl_band_list *band_list = isl_schedule_get_band_forest (schedule);
+  isl_union_map *schedule_map = get_schedule_for_band_list (band_list);
    isl_band_list_free (bandList);
    return schedule_map;
  }

Building arm-none-linux-gnueabihf fails at the isl_band_list_free. Shouldn't bandList
be band_list?

Kyrill points out that it's already fixed: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01613.html

Matthew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]