This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/5] Don't mark targets of unconditional jumps with side effects as FALLTHRU.

On 21/01/16 11:05, Andreas Krebbel wrote:

On 01/02/2016 08:16 PM, Marcin KoÅcielnicki wrote:

When an unconditional jump with side effects targets an immediately
following label, rtl_tidy_fallthru_edge is called.  Since it has side
effects, it doesn't remove the jump, but the label is still marked
as fallthru.  This later causes a verification error.  Do nothing in this
case instead.

gcc/ChangeLog:

	* cfgrtl.c (rtl_tidy_fallthru_edge): Bail for unconditional jumps
	with side effects.


The change looks ok to me (although I'm not able to approve it). Could you please run regressions
tests on x86_64 with that change?

Perhaps a short comment in the code would be good.

-Andreas-



OK, I'll run the testsuite and add a comment.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]