This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [hsa merge 02/10] Modifications to libgomp proper
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ilya Verbin <iverbin at gmail dot com>
- Cc: Martin Jambor <mjambor at suse dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 20 Jan 2016 15:55:48 +0100
- Subject: Re: [hsa merge 02/10] Modifications to libgomp proper
- Authentication-results: sourceware.org; auth=none
- References: <20160113173925 dot 220029649 at virgil dot suse dot cz> <20160113173925 dot 431228371 at virgil dot suse dot cz> <20160120144759 dot GB49431 at msticlxl57 dot ims dot intel dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Jan 20, 2016 at 05:47:59PM +0300, Ilya Verbin wrote:
> OK for trunk?
>
> libgomp/
> * task.c (gomp_create_target_task): Set firstprivate_copies to NULL.
>
> diff --git a/libgomp/task.c b/libgomp/task.c
> index 0f45c44..38d4e9b 100644
> --- a/libgomp/task.c
> +++ b/libgomp/task.c
> @@ -683,6 +683,7 @@ gomp_create_target_task (struct gomp_device_descr *devicep,
> ttask->state = state;
> ttask->task = task;
> ttask->team = team;
> + ttask->firstprivate_copies = NULL;
> task->fn = NULL;
> task->fn_data = ttask;
> task->final_task = 0;
Ok (though, eventually I'd prefer if free (ttask->firstprivate_copies) is
only performed for the shared mem async tasks and not other one.
Jakub