This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM] PR68674 Fix LTO support for neon builtin and error catching (ping)
- From: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
- To: Christian Bruel <christian dot bruel at st dot com>, "Richard dot Earnshaw at arm dot com" <Richard dot Earnshaw at arm dot com>, "ramana dot radhakrishnan at foss dot arm dot com" <ramana dot radhakrishnan at foss dot arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 14 Jan 2016 15:23:42 +0000
- Subject: Re: [PATCH, ARM] PR68674 Fix LTO support for neon builtin and error catching (ping)
- Authentication-results: sourceware.org; auth=none
- References: <568D1E7B dot 1090609 at st dot com> <568D3B10 dot 6080309 at foss dot arm dot com> <568D3F76 dot 2020202 at foss dot arm dot com> <568D4B4D dot 2010304 at st dot com> <568D4D28 dot 8010500 at foss dot arm dot com> <56979685 dot 4050406 at st dot com>
Hi Christian,
On 14/01/16 12:37, Christian Bruel wrote:
Here is the rebased patch after the #pragma GCC target warning fixes.
I also disabled the builtins initialisations when float-abi is solft as you suggested
This is ok with a couple of nits below addressed:
+/* Set up all the NEON builtins, even builtins for instructions that are not
+ in the current target ISA to allow the user to compile particular modules
+ with different target specific options that differ from the command line
+ options. */
static void
-arm_init_neon_builtins_internal (void)
+arm_init_neon_builtins (void)
New line between comment and function type.
Also, can you please mention in the comment that while we set up builtins
that might not be supported for the current ISA, we still reject them during expand time.
Thanks for iterating on this!
Kyrill