This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test

From: Nick Clifton <nickc at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org
Date: Thu, 7 Jan 2016 21:04:20 +0000
Subject: Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test
Authentication-results: sourceware.org; auth=none
References: <87egejk7mj dot fsf at redhat dot com> <56785A36 dot 60507 at redhat dot com> <56791DBB dot 3050800 at redhat dot com> <568C1777 dot 8070801 at redhat dot com> <568E6A14 dot 1030007 at redhat dot com> <568E8B94 dot 5030606 at redhat dot com> <568EA0E1 dot 6060801 at redhat dot com> <20160107174159 dot GH18720 at tucnak dot redhat dot com>

Hi Jakub,

-extern size_t __fread_chk (void *__restrict __ptr, size_t __ptrlen, size_t
__size, size_t __n, FILE *__restrict __stream) __asm__ ("" "__fread_chk")
__attribute__ ((__warn_unused_result__));

+extern size_t __malloc (void *__restrict __ptr, size_t __ptrlen, size_t
__size, size_t __n, FILE *__restrict __stream) __asm__ ("") __attribute__
((__warn_unused_result__));

The __asm__ ("") on both decls is very weird.  The original had
"" "__fread_chk" aka "__fread_chk" instead.

What does that do ? I could not find a reference to it in thedocumentation.

But malloc really has also different arguments...

True - thinking about it afterwards it occurred to me that renaming thefunction to just "fread" would be a lot better ...


Cheers
  Nick

References:
- Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test
  - From: Jeff Law
- Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test
  - From: Nick Clifton
- Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test
  - From: Jeff Law
- Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test
  - From: Nick Clifton
- Re: RFA: PR 68913: Provide weak version of __fread_chk for PR61886 test
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]