This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM] PR68674 Fix LTO support for neon builtin and error catching (ping)
- From: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
- To: Christian Bruel <christian dot bruel at st dot com>, Richard dot Earnshaw at arm dot com, ramana dot radhakrishnan at foss dot arm dot com, gcc-patches at gcc dot gnu dot org
- Date: Wed, 06 Jan 2016 14:45:34 +0000
- Subject: Re: [PATCH, ARM] PR68674 Fix LTO support for neon builtin and error catching (ping)
- Authentication-results: sourceware.org; auth=none
- References: <568D1E7B dot 1090609 at st dot com>
Hi Christian,
On 06/01/16 14:02, Christian Bruel wrote:
ping/respin https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01095.html.
This patch fixes LTO for neon builtins defined with attribute target or in a pragma region.
It also fixes a few discrepancies due to the unavailability of the neon builtins and types at function startup. So we now set up the builtins even if not available in the current arch to allow the user to compile different fragments with
target specific attributes. The check is done in arm_expand_builtin.
The discussed chunk around arm_vector_mode_supported_p is now obsolete since https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01714.html.
I also changed the error messages as suggested by Ramana
New regression tests describing the different issues included. Tested with no new failures for arm-sim/\{,-mfpu=vfp,-mfpu=neon}{,-march=armv7-a\}.
Thanks for following up.
I'd like to do perform a bootstrap of this patch.
If you didn't run one already, I'll kick one off overnight.
The patch looks ok to me upon inspection and having looked deeper at the previous version,
but I'll take a closer look while waiting for the bootstrap to run.
Also, could you please add the appropriate PR entries in your changelog so that we can keep track of
which PRs are being solved.
Thanks,
Kyrill
regards,