This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] libiberty: support demangling of rvalue reference typenames
- From: Artemiy Volkov <artemiyv at acm dot org>
- To: Ian Lance Taylor <ian at airs dot com>
- Cc: gcc-patches at gcc dot gnu dot org, dj at redhat dot com
- Date: Tue, 5 Jan 2016 16:59:03 +0300
- Subject: Re: [PATCH] libiberty: support demangling of rvalue reference typenames
- Authentication-results: sourceware.org; auth=none
- References: <1451958209-29170-1-git-send-email-artemiyv at acm dot org> <m3y4c45zm3 dot fsf at pepe dot airs dot com> <20160105075727 dot GA2876 at gmail dot com> <m3twms5f97 dot fsf at pepe dot airs dot com>
On Tue, Jan 05, 2016 at 05:26:28AM -0800, Ian Lance Taylor wrote:
> Artemiy Volkov <artemiyv@acm.org> writes:
>
> > On Mon, Jan 04, 2016 at 10:06:44PM -0800, Ian Lance Taylor wrote:
> >> Artemiy Volkov <artemiyv@acm.org> writes:
> >>
> >> > This patch adds handling of 'O' (rvalue ref) type codes in the C++
> >> > demangling
> >> > code which is done similarly to the 'R' (regular references)
> >> > case. It also adds
> >> > a few testcases for various demangling styles which are just
> >> > mirrored versions
> >> > of the corresponding regular references demangling tests.
> >> >
> >> > libiberty/ChangeLog:
> >> >
> >> > 2016-01-04 Artemiy Volkov <artemiyv@acm.org>
> >> >
> >> > * cplus-dem.c (enum type_kind_t): Add tk_rvalue_reference
> >> > constant.
> >> > (demangle_template_value_parm): Handle tk_rvalue_reference
> >> > type kind.
> >> > (do_type): Support 'O' type id (rvalue references).
> >>
> >> Is there a compiler that actually generate these symbols?
> >
> > Sure, at least gcc and clang generate this. E.g. when compiling:
> >
> > void f(int&& b) { }
> >
> > you then have:
> >
> > â nm 1.o
> > 0000000000000000 T _Z1fOi
>
> That symbol name is handled by code in cp-demangle.c, not cplus-dem.c.
> It already works today. Try it. cplus-dem is the old (very old)
> demangler. cp-demangle is the current demangler.
Sorry, I believe I should have mentioned that this patch is for the
needs of gdb, whose demangle command still pretty much uses the old
demangler in cplus-dem.c. I was working on rvalue references support in
gdb (https://sourceware.org/ml/gdb-patches/2015-12/msg00407.html) and
AIUI all the patches for libiberty should go through this mailing list,
that's why I sent the libiberty part here to later merge it to gdb.
>
> Ian