This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/2] PR c/68757: fix uninitialied src_range for various builtins
- From: Bernd Schmidt <bschmidt at redhat dot com>
- To: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 8 Dec 2015 16:38:06 +0100
- Subject: Re: [PATCH 1/2] PR c/68757: fix uninitialied src_range for various builtins
- Authentication-results: sourceware.org; auth=none
- References: <1449589428-10681-1-git-send-email-dmalcolm at redhat dot com>
On 12/08/2015 04:43 PM, David Malcolm wrote:
This fixes various uninitialized src_range of c_expr, this time
in the various builtins that are parsed via c_parser_get_builtin_args.
Bootstrapped®rtested on x86_64-pc-linux-gnu.
OK for trunk?
I think both of these patches are OK. Some questions though.
" a constant");
constant_expression_warning (c);
expr = integer_zerop (c) ? *e3_p : *e2_p;
+ set_c_expr_source_range (&expr, loc, close_paren_loc);
If that had an uninitialized range, it implies that the *eN_p
expressions also have uninitialized parts. Correct? If so, I think we
should fix that.
Also, what happened to the idea of a constructor for c_expr_t?
Bernd