Re: [PATCH] Fix PR68029

[JiÅÃ Engelthaler <engycz at gmail dot com>]

2015-11-27 13:49 GMT+01:00 Bernd Schmidt <bschmidt@redhat.com>:
> On 11/27/2015 01:30 PM, JiÅÃ Engelthaler wrote:
>>
>> Sorry for international characters in my name. It should be
>>
>> Jiri Engelthaler
>>
>> 2015-11-27 13:29 GMT+01:00 Engelthaler JiÅÃ <Jiri.Engelthaler@zat.cz>:
>
>
> There is precedent for non-ASCII characters in ChangeLogs. Grep for Rafael
> Ãvila de EspÃndola. But I think there should be two spaces before the email
> address.

You are right - two spaces.

>>         PR driver/68029
>>         * opts-common.c (prune_options): fdiagnostics_color ignored
>>         if it was as first parameter
>
>
> This should read "Don't ignore -fdiagnostics-color if it is the first
> parameter." Full sentences with punctuation.

Changelog modified.

Thank you for recommendation, this is my first patch to GCC.

Engy

Attachment: CL_68029.txt
Description: Text document

Attachment: patch_68029.txt
Description: Text document