This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR68029
- From: JiÅÃ Engelthaler <engycz at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 27 Nov 2015 14:10:09 +0100
- Subject: Re: [PATCH] Fix PR68029
- Authentication-results: sourceware.org; auth=none
- References: <CAHODtZTCthR7sA5DDbeZWXF0CEAsg45CZdHKk0n8zWg4+jTnkw at mail dot gmail dot com> <56585176 dot 3070907 at redhat dot com>
2015-11-27 13:49 GMT+01:00 Bernd Schmidt <bschmidt@redhat.com>:
> On 11/27/2015 01:30 PM, JiÅÃ Engelthaler wrote:
>>
>> Sorry for international characters in my name. It should be
>>
>> Jiri Engelthaler
>>
>> 2015-11-27 13:29 GMT+01:00 Engelthaler JiÅÃ <Jiri.Engelthaler@zat.cz>:
>
>
> There is precedent for non-ASCII characters in ChangeLogs. Grep for Rafael
> Ãvila de EspÃndola. But I think there should be two spaces before the email
> address.
You are right - two spaces.
>> PR driver/68029
>> * opts-common.c (prune_options): fdiagnostics_color ignored
>> if it was as first parameter
>
>
> This should read "Don't ignore -fdiagnostics-color if it is the first
> parameter." Full sentences with punctuation.
Changelog modified.
Thank you for recommendation, this is my first patch to GCC.
Engy