This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR68432 04/22] Remove global which_alternative
- From: Bernd Schmidt <bschmidt at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org, richard dot sandiford at arm dot com
- Date: Wed, 25 Nov 2015 17:06:06 +0100
- Subject: Re: [PR68432 04/22] Remove global which_alternative
- Authentication-results: sourceware.org; auth=none
- References: <874mgajmo9 dot fsf at e105548-lin dot cambridge dot arm dot com> <87k2p6i7tr dot fsf at e105548-lin dot cambridge dot arm dot com>
On 11/25/2015 01:26 PM, Richard Sandiford wrote:
Later patches in the series add a new form of attribute that takes the
attribute number as an argument, rather than it being stored in the
global which_alternative variable.
Having both a local alternative number and a global alternative number
is likely to cause confusion. This patch therefore gets rid of the
global variable.
I don't really feel that this is appropriate for this stage, and some of
the formatting changes are pretty ugly. I'd put this pattern
constrain_operands (1, get_enabled_alternatives (temp)) >= 0
into an inline function
constraints_ok_p (temp).
and possibly also have a variant with an extract_insn call, similar to
extract_constrain_insn.
Do any of the subsequent patches actually depend on this?
Bernd