This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [ptx] Fix sso tests

From: Jeff Law <law at redhat dot com>
To: Nathan Sidwell <nathan at acm dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: Bernd Schmidt <bschmidt at redhat dot com>
Date: Mon, 23 Nov 2015 13:41:59 -0700
Subject: Re: [ptx] Fix sso tests
Authentication-results: sourceware.org; auth=none
References: <5653740C dot 9010507 at acm dot org>

On 11/23/2015 01:16 PM, Nathan Sidwell wrote:

The gcc.dg/sso tests gratuitously fail on PTX because they use IO
facilities that don't exist there.  This  patch changes the dumping to
use the putchar function call (and not a macro), and not use fputs.

With this they all pass.

I'm not quite sure where the maintainer  boundaries lie for this kind of
fix. Any objections?

In the 'put' function, why not just make all targets go through putchar?It's not like this is performance critical code and I don't think itcompromises any of the tests, does it?


jeff

Follow-Ups:
- Re: [ptx] Fix sso tests
  - From: Nathan Sidwell

References:
- [ptx] Fix sso tests
  - From: Nathan Sidwell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]